Skip to content

[flashloan] aave_live.rs integration test not gated — breaks cargo test --workspace in CI #139

@obchain

Description

@obchain

Refs #39

File: crates/charon-flashloan/tests/aave_live.rs

Problem

The live integration test opens a WebSocket to BSC mainnet. CI and clean developer checkouts have no BNB_WS_URL set. CLAUDE.md pre-commit gate: cargo test --workspace must pass. This test will fail unconditionally in any environment without a live BSC RPC, blocking every CI run and every contributor without a funded RPC endpoint.

The charon-scanner crate gates its live tests with:

if std::env::var("CHARON_LIVE_RPC").is_err() { return; }

or marks them #[ignore] so they only execute with cargo test -- --include-ignored.

Impact: All CI runs fail. Pre-commit gate is broken for all contributors without a live RPC.

Fix

Annotate every test function in aave_live.rs with #[ignore], or add an env-var guard at the start of each test body matching the charon-scanner pattern. Add a comment at the top of the file:

// Run with: CHARON_LIVE_RPC=1 BNB_WS_URL=wss://... cargo test -p charon-flashloan -- --include-ignored

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinglayer:rustRust crates (core / scanner / protocols / executor / cli)priority:p1-coreCore MVP scope

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions