Skip to content

[executor] charon-executor crate not in workspace members — clippy/test/fmt silently skipped #176

@obchain

Description

@obchain

Refs #42

PR: feat(cli): wire scanner → router → builder → simulator pipeline (feat/17-cli-e2e-pipeline)
Commit: latest on feat/17-cli-e2e-pipeline
File: Cargo.toml (root workspace members array)

Problem:

PR #42 introduces crates/charon-executor (builder.rs + simulation.rs). The root Cargo.toml workspace members array is:

members = [
    "crates/charon-core",
    "crates/charon-protocols",
    "crates/charon-scanner",
    "crates/charon-cli",
]

crates/charon-executor is absent. This means:

  • cargo clippy --workspace --all-targets --all-features -- -D warnings silently skips the crate.
  • cargo test --workspace does not run charon-executor tests.
  • cargo fmt --all does not format charon-executor source.
  • CLAUDE.md pre-commit gates pass while executor lint and test violations go undetected.

This is the same issue as PR #39 finding 5 for charon-flashloan. The pattern is recurring: new crates are not added to workspace members.

charon-executor contains TxBuilder and Simulator — the components closest to broadcast. Their correctness is the most critical to enforce via CI.

Impact: All lint violations, unsafe code, and test failures in charon-executor are invisible to CI and the pre-commit hook.

Fix: Add "crates/charon-executor" to the members array in the root Cargo.toml. Add charon-executor to [workspace.dependencies] if it is a dependency of charon-cli. Verify cargo build --workspace passes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinglayer:rustRust crates (core / scanner / protocols / executor / cli)pr-reviewFindings from PR review processpriority:p1-coreCore MVP scopestatus:readyScoped and ready to pick uptype:choreMaintenance, config, tooling

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions