Skip to content

[contracts] evm_version=paris absent from foundry.toml — batchExecute compiled for wrong EVM target #203

@obchain

Description

@obchain

PR: #45 (feat/20-multi-liq-batcher)
File: contracts/foundry.toml

foundry.toml on this branch has no evm_version key. solc 0.8.24 defaults to shanghai, which emits the PUSH0 opcode. BSC does not support PUSH0. All contracts compiled from this branch — including the new batchExecute function and its Foundry tests — produce bytecode that will fault on BSC at any PUSH0 site.

This is the same defect originally flagged in PR #36 (issues #114/#118) and PR #37, carried forward unresolved into every subsequent Solidity PR.

Impact: Every batchExecute test runs against miscompiled bytecode. Any deployed build from this branch will fault on BSC mainnet.

Fix: Add evm_version = "paris" to [profile.default] in contracts/foundry.toml.

Refs #45

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinglayer:contractsSolidity / Foundrypr-reviewFindings from PR review processpriority:p0-blockerBlocks the critical pathstatus:readyScoped and ready to pick up

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions