Skip to content

Comments

community: Make behaviour of CTRL more similar to Minecraft#84

Closed
Arta48 wants to merge 3 commits intoobiwac:mobsfrom
Arta48:mobs
Closed

community: Make behaviour of CTRL more similar to Minecraft#84
Arta48 wants to merge 3 commits intoobiwac:mobsfrom
Arta48:mobs

Conversation

@Arta48
Copy link

@Arta48 Arta48 commented Feb 7, 2023

i make CTRL working as in Minecraft

I mean when you sprinting and release CTRL, you stop sprinting. I fix it, sprinting stops when you stop pressing W. Also when you hold CTRL, press W, release W and press W again, sprinting doesn't work. It's also fixed. FOV increases when standing, etc. are fixed.

@obiwac obiwac added the enhancement New feature or request label Feb 7, 2023
@obiwac
Copy link
Owner

obiwac commented Feb 7, 2023

Hey, thanks for the PR, could you elaborate on what you mean by this more specifically?

I'll review the patch a little later :)

Repository owner deleted a comment from Arta48 Feb 7, 2023
@obiwac
Copy link
Owner

obiwac commented Feb 7, 2023

Please let me add your comment to your PR description - it's easier for people to know what the PR is about 😄

Repository owner deleted a comment from Arta48 Feb 7, 2023
@Arta48
Copy link
Author

Arta48 commented Feb 7, 2023

It probably went wrong

Copy link
Owner

@obiwac obiwac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems generally pretty good. Could you make your commit name a little more descriptive though? Also, if you could squash the two commits you made into one that would be great.

I assume you've used the GitHub web interface to do your modifications - I'd recommend using git locally to make your changes, or, alternatively, GitHub Desktop or GitKraken.

I can also commit in your place if you don't feel like doing it :)

@obiwac obiwac changed the title Fix CTRL Working community: Make behaviour of CTRL more similar to in Minecraft Feb 7, 2023
@obiwac obiwac changed the title community: Make behaviour of CTRL more similar to in Minecraft community: Make behaviour of CTRL more similar to Minecraft Feb 7, 2023
@Arta48
Copy link
Author

Arta48 commented Feb 7, 2023

I can also commit in your place if you don't feel like doing it :)

Yes, this is difficult for me

@obiwac
Copy link
Owner

obiwac commented Feb 7, 2023

Committed :)

@obiwac obiwac closed this Feb 7, 2023
@Arta48
Copy link
Author

Arta48 commented Feb 7, 2023

Good luck :)

Arta48

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants