Skip to content

Do not use sentiment at all. Always take the answer text. #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkimberlin merged 1 commit into from
Nov 13, 2024
Merged

Do not use sentiment at all. Always take the answer text. #2763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions server/src/main/java/com/objectcomputing/checkins/services/reports/ReportDataCollation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,12 +306,7 @@ private List<Feedback> getFeedbackType(FeedbackType type) {
feedbackAnswers.add(
new Feedback.Answer(
recipientName, request.getSubmitDate(), questionText,
questionType.equals(textQuestion) ||
questionType.equals(radioQuestion) ?
answer.getAnswer() :
String.valueOf(answer.getSentiment()),
questionType,
questionNumber));
answer.getAnswer(), questionType, questionNumber));
}
}
}
Expand Down
31 changes: 0 additions & 31 deletions web-ui/src/pages/MeritReportPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,6 @@ import { useQueryParameters } from '../helpers/query-parameters';
import markdown from 'markdown-builder';

const MeritReportPage = () => {
const agreeMarks = [
'Strongly Disagree',
'Disagree',
'Neither Agree nor Disagree',
'Agree',
'Strongly Agree'
];
const frequencyMarks = [
'Very Infrequently',
'Infrequently',
'Neither Frequently nor Infrequently',
'Frequently',
'Very Frequently'
];

const { state, dispatch } = useContext(AppContext);

const csrf = selectCsrfToken(state);
Expand Down Expand Up @@ -338,22 +323,6 @@ const MeritReportPage = () => {
};

const getAnswerText = (answer) => {
if (answer.type == "SLIDER" || answer.type == "FREQ") {
const sentiment = parseFloat(answer.answer);
if (!isNaN(sentiment)) {
if (answer.type == "SLIDER") {
const index = sentiment * agreeMarks.length;
if (index >= 0 && index < agreeMarks.length) {
return agreeMarks[index];
}
} else if (answer.type == "FREQ") {
const index = sentiment * frequencyMarks.length;
if (index >= 0 && index < frequencyMarks.length) {
return frequencyMarks[index];
}
}
}
}
return answer.answer;
};

Expand Down