Skip to content

Send null for externalScore if not provided and handle null external … #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkimberlin merged 1 commit into from
Jan 9, 2025
Merged

Send null for externalScore if not provided and handle null external … #2816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web-ui/src/pages/PulsePage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const PulsePage = () => {
const myId = currentUser?.id;
const data = {
externalFeelings: externalComment,
externalScore: externalScore + 1, // converts to 1-based
externalScore: externalScore == null ? null : externalScore + 1, // converts to 1-based
internalFeelings: internalComment,
internalScore: internalScore + 1, // converts to 1-based
submissionDate: today,
Expand Down
8 changes: 6 additions & 2 deletions web-ui/src/pages/PulseReportPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,9 @@ const PulseReportPage = () => {
}

frequencies[internalScore - 1].internal++;
frequencies[externalScore - 1].external++;
if (externalScore != null) {
frequencies[externalScore - 1].external++;
}

let memberIdToUse;
if (memberId) {
Expand Down Expand Up @@ -256,7 +258,9 @@ const PulseReportPage = () => {
];
for(let day of scoreChartDataPoints) {
day.datapoints.forEach(datapoint => {
externalPieCounts[datapoint.externalScore - 1].value++;
if (datapoint.externalScore != null) {
externalPieCounts[datapoint.externalScore - 1].value++;
}
});
}
// Filter out data with a zero value so that the pie chart does not attempt
Expand Down
Loading