Skip to content

Mark externalScore nullable so that we can pull responses with null v… #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkimberlin merged 2 commits into from
Jan 9, 2025
Merged

Mark externalScore nullable so that we can pull responses with null v… #2817

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a71b1a1
Mark externalScore nullable so that we can pull responses with null v…
ocielliottc Jan 9, 2025
1bd9873
Merge branch 'develop' into bugfix-2815/pulse-no-external-score
mkimberlin Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public class PulseResponse {
protected PulseResponse() {
}

public PulseResponse(UUID id, Integer internalScore, Integer externalScore, LocalDate submissionDate, @Nullable UUID teamMemberId, String internalFeelings, String externalFeelings) {
public PulseResponse(UUID id, Integer internalScore, @Nullable Integer externalScore, LocalDate submissionDate, @Nullable UUID teamMemberId, String internalFeelings, String externalFeelings) {
this.id = id;
this.internalScore = internalScore;
this.externalScore = externalScore;
Expand Down
Loading