Feature 2814/slack pulse survey integration#2820
Merged
mkimberlin merged 14 commits intodevelopfrom Jan 31, 2025
Merged
Conversation
mkimberlin
reviewed
Jan 30, 2025
| return pulse.internalScore > 0 && pulse.internalScore <= 5 && | ||
| (pulse.externalScore == null || | ||
| (pulse.externalScore > 0 && pulse.externalScore <= 5)); | ||
| }); |
Member
There was a problem hiding this comment.
Do we have bad data somewhere?
Collaborator
Author
There was a problem hiding this comment.
There is nothing that restricts externalScore from being any integer value. When I was testing, just for fun, I decided to send values outside of that range and it did not deal well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs to be deployed to an external server to continue development.
There is an extraneous change on this branch where I renamed
sendPendingEmailmethod tonotifyUsersbecause I originally thought that we were going to push the Pulse form out to the users. It is now up to the user to run the slash command:/pulseto initiate the Slack pulse flow.