Skip to content

Bugfix 2845/home give kudos #2846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkimberlin merged 3 commits into from
Feb 5, 2025
Merged

Bugfix 2845/home give kudos #2846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23cc64a
Display the "Give Kudos" button if the member has permission to creat…
ocielliottc Jan 28, 2025
e08b9d3
Updated snapshot
ocielliottc Jan 28, 2025
5518391
Merge branch 'develop' into bugfix-2845/home-give-kudos
mkimberlin Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions web-ui/src/components/kudos/PublicKudos.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ import React, { useCallback, useContext, useEffect, useState } from 'react';

import { UPDATE_TOAST } from '../../context/actions';
import { AppContext } from '../../context/AppContext';
import { selectCsrfToken } from '../../context/selectors';
import {
selectCsrfToken,
selectHasCreateKudosPermission,
} from '../../context/selectors';
import { sortKudos } from '../../context/util';

import { getRecentKudos } from '../../api/kudos';
Expand Down Expand Up @@ -45,13 +48,13 @@ const PublicKudos = () => {
<div className="public-kudos">
<div className="kudos-title">
<h1>Kudos</h1>
<Button
{selectHasCreateKudosPermission(state) && <Button
className="kudos-dialog-open"
startIcon={<StarIcon />}
onClick={() => setKudosDialogOpen(true)}
>
Give Kudos
</Button>
</Button>}
</div>
<KudosDialog
open={kudosDialogOpen}
Expand Down
25 changes: 0 additions & 25 deletions web-ui/src/pages/__snapshots__/HomePage.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,31 +24,6 @@ exports[`renders correctly 1`] = `
<h1>
Kudos
</h1>
<button
class="MuiButtonBase-root MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeMedium MuiButton-textSizeMedium MuiButton-colorPrimary MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeMedium MuiButton-textSizeMedium MuiButton-colorPrimary kudos-dialog-open css-1e6y48t-MuiButtonBase-root-MuiButton-root"
tabindex="0"
type="button"
>
<span
class="MuiButton-icon MuiButton-startIcon MuiButton-iconSizeMedium css-1d6wzja-MuiButton-startIcon"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="StarIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M12 17.27 18.18 21l-1.64-7.03L22 9.24l-7.19-.61L12 2 9.19 8.63 2 9.24l5.46 4.73L5.82 21z"
/>
</svg>
</span>
Give Kudos
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</button>
</div>
<div
class="MuiGrid-root MuiGrid-container MuiGrid-spacing-xs-3 css-zow5z4-MuiGrid-root"
Expand Down
Loading