Skip to content

Dynamically determine the confetti location based on existence of … #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkimberlin merged 2 commits into from
Feb 5, 2025
Merged

Dynamically determine the confetti location based on existence of … #2848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d7d5ff
Dynamically determine the confetti location based on existence of ann…
ocielliottc Jan 29, 2025
9a9a961
Merge branch 'develop' into bugfix-2847/confetti-location
mkimberlin Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions web-ui/src/pages/HomePage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ export default function HomePage() {
const kudosStyle = birthdays.length == 0 &&
anniversaries.length == 0 ? {} : { width: '450px' };

// Determine the X position of the birthday confetti. If there aren't any
// anniversaries, it will be the left side. If there are anniversaries, we
// need it in the middle. Confetti X position ranges from 0 to 1.
const xPos = anniversaries.length > 0 ? .5 : .25;

return (
<div className="home-page">
<div className="celebrations">
Expand All @@ -95,13 +100,13 @@ export default function HomePage() {
/>
) : (
<Grid container spacing={2} style={{ padding: '0 20px 0 20px' }}>
{ anniversaries.length > 0 && (
{ anniversaries.length > 0 && (
<Grid item>
<Anniversaries anniversaries={anniversaries} />
</Grid>) }
{ birthdays.length > 0 && (
<Grid item>
<Birthdays birthdays={birthdays} />
<Birthdays birthdays={birthdays} xPos={xPos} />
</Grid>) }
<Grid item style={kudosStyle}>
<PublicKudos />
Expand Down
Loading