Intercept 401 errors, pop up a login window that closes when successful.#2851
Merged
mkimberlin merged 3 commits intodevelopfrom Feb 5, 2025
Merged
Intercept 401 errors, pop up a login window that closes when successful.#2851mkimberlin merged 3 commits intodevelopfrom
mkimberlin merged 3 commits intodevelopfrom
Conversation
1 task
mkimberlin
reviewed
Feb 5, 2025
| }, 1000); | ||
| }); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I think this is only workable for localhost, isn't it?
Collaborator
Author
There was a problem hiding this comment.
I think it works elsewhere because the URL doesn't really matter (except for our route match to close the window). In production, it will see that the JWT has expired (or doesn't exist) and will make the user pick their google account to use.
Member
|
I've never been so excited to see if something works. 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.