Skip to content

It looks like a block id is required to retrieve values from the post… #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkimberlin merged 1 commit into from
Feb 3, 2025
Merged

It looks like a block id is required to retrieve values from the post… #2861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 38 additions & 12 deletions ...java/com/objectcomputing/checkins/services/pulseresponse/SlackPulseResponseConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,22 +42,25 @@ public PulseResponseCreateDTO get(
final Map<String, Object> values =
(Map<String, Object>)state.get("values");

dumpMap(values, "");

// Create the pulse DTO and fill in the values.
PulseResponseCreateDTO response = new PulseResponseCreateDTO();
response.setTeamMemberId(lookupUser(memberProfileServices, map));
response.setSubmissionDate(LocalDate.now());

response.setInternalScore(Integer.parseInt(
getMappedValue(values, "internalScore", true)));
response.setInternalFeelings(
getMappedValue(values, "internalFeelings", false));
response.setInternalScore(Integer.parseInt(getMappedValue(
values, "internalNumber", "internalScore", true)));
response.setInternalFeelings(getMappedValue(
values, "internaltext", "internalFeelings", false));

String score = getMappedValue(values, "externalScore", false);
String score = getMappedValue(values, "externalScore",
"externalScore", false);
if (!score.isEmpty()) {
response.setExternalScore(Integer.parseInt(score));
}
response.setExternalFeelings(
getMappedValue(values, "externalFeelings", false));
response.setExternalFeelings(getMappedValue(
values, "externalText", "externalFeelings", false));

return response;
} catch(JsonProcessingException ex) {
Expand All @@ -69,20 +72,32 @@ public PulseResponseCreateDTO get(
}
}

private String getMappedValue(Map<String, Object> map,
private String getMappedValue(Map<String, Object> map, String blockId,
String key, boolean required) {
if (!map.containsKey(blockId)) {
if (required) {
throw new BadArgException(
String.format("Block ID - %s was not found", blockId));
} else {
return "";
}
}
Map<String, Object> blockMap = (Map<String, Object>)map.get(blockId);

final String valueKey = "value";
if (map.containsKey(key)) {
final Map<String, Object> other = (Map<String, Object>)map.get(key);
if (blockMap.containsKey(key)) {
final Map<String, Object> other =
(Map<String, Object>)blockMap.get(key);
if (other.containsKey(valueKey)) {
return (String)other.get(valueKey);
}
}

if (required) {
LOG.error("Expected {}.{} was not found", key, valueKey);
LOG.error("Expected {}.{}.{} was not found", blockId, key, valueKey);
throw new BadArgException(
String.format("Expected %s.%s was not found", key, valueKey));
String.format("Expected %s.%s.%s was not found",
blockId, key, valueKey));
} else {
return "";
}
Expand All @@ -101,4 +116,15 @@ private UUID lookupUser(MemberProfileServices memberProfileServices,
MemberProfile member = memberProfileServices.findByWorkEmail(email);
return member.getId();
}

// DEBUG Only
private void dumpMap(Map<?, ?> map, String indent) {
for (Map.Entry<?, ?> entry : map.entrySet()) {
LOG.info(indent + entry.getKey() + " : " + entry.getValue());

if (entry.getValue() instanceof Map) {
dumpMap((Map<?, ?>) entry.getValue(), indent + " ");
}
}
}
}
4 changes: 4 additions & 0 deletions server/src/main/resources/slack/pulse_slack_blocks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"blocks": [
{
"type": "section",
"block_id": "internalNumber",
"text": {
"type": "plain_text",
"text": "How are you feeling about work today?"
Expand Down Expand Up @@ -71,6 +72,7 @@
},
{
"type": "input",
"block_id": "internalText",
"optional": true,
"element": {
"type": "plain_text_input",
Expand All @@ -88,6 +90,7 @@
},
{
"type": "section",
"block_id": "externalNumber",
"text": {
"type": "plain_text",
"text": "How are you feeling about life outside of work?"
Expand Down Expand Up @@ -141,6 +144,7 @@
},
{
"type": "input",
"block_id": "externalText",
"optional": true,
"element": {
"type": "plain_text_input",
Expand Down
Loading