Skip to content

Feature 2872/kudos surplus tooltip #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkimberlin merged 6 commits into from
Feb 17, 2025
Merged

Feature 2872/kudos surplus tooltip #2884

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c8826ba
Implement a tooltip for the surplus icon with the names of the extra …
ocielliottc Feb 13, 2025
b50e0eb
Use the same surplus renderer for team kudos.
ocielliottc Feb 13, 2025
efa3d23
Remove unnecessary (and possibly duplicate key).
ocielliottc Feb 14, 2025
14cd1d9
Wrap text in Typography to avoid React Mui warning.
ocielliottc Feb 14, 2025
b8d40ea
Merge branch 'develop' into feature-2872/kudos-surplus-tooltip
mkimberlin Feb 14, 2025
f143d4a
Merge branch 'develop' into feature-2872/kudos-surplus-tooltip
mkimberlin Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions web-ui/src/components/kudos/PublicKudosCard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,18 @@ const KudosCard = ({ kudos }) => {

const sender = selectProfile(state, kudos.senderId);

const multiTooltip = (num, list) => {
let tooltip = "";
let prefix = "";
for (let member of list.slice(-num)) {
tooltip += prefix + `${member.firstName} ${member.lastName}`;
prefix = ", ";
}
return <Tooltip arrow title={tooltip}>
<Typography>{`+${num}`}</Typography>
</Tooltip>;
};

const getRecipientComponent = useCallback(() => {
if (kudos.recipientTeam) {
return (
Expand All @@ -67,7 +79,9 @@ const KudosCard = ({ kudos }) => {
}

return (
<AvatarGroup max={4}>
<AvatarGroup max={4}
renderSurplus={(extra) => multiTooltip(
extra, kudos.recipientMembers)}>
{kudos.recipientMembers.map((member) => (
<Tooltip
arrow
Expand Down Expand Up @@ -100,7 +114,9 @@ const KudosCard = ({ kudos }) => {
<CardContent>
<Typography variant="body1"><em>{kudos.message}</em></Typography>
{kudos.recipientTeam && (
<AvatarGroup max={12}>
<AvatarGroup max={12}
renderSurplus={(extra) => multiTooltip(
extra, kudos.recipientMembers)}>
{kudos.recipientMembers.map((member) => (
<Tooltip
arrow
Expand Down
Loading