Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR indents to fix a few issues I encountered when integrating mFAST in my own projects. Mainly the fact that
find_package(mFAST)will modifyCMAKE_CXX_FLAGSandCMAKE_CXX_STANDARD. This was a bit intrusive, and now the targets are setup to carry their usage requirements without touching global CMake config.In the process I did a few other modifications:
hiddenfor all targets (matters for LTO performance)ONfor the same reasonFILE_SET HEADERS, removing the need to make aninstall(FILES)rules for themmFASTConfig.cmake.inandmFASTConfigVersion.cmake.in)file(GLOB)used for the source to be refreshed on build withCONFIGURE_DEPENDSResolves #122