fix(android): soft exception when library try to access RCTDeviceEventEmitter before it is initialised#117
Merged
oblador merged 1 commit intooblador:masterfrom Oct 23, 2025
Conversation
This was referenced Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the improvement introduced here: #107
Currently, the app isn't crashing, but it's throwing soft exceptions when trying to emit events before
RCTDeviceEventEmitteris initialisedTo fix this, I wrapped the second emit with
and changed the previous
hasActiveCatalystInstance()tohasActiveReactInstance()as it has been deprecated