document window#1349
Merged
Merged
Conversation
remarks: * *k* is not optional * *shift* is deprecated * added the *strict* option to README
56 tasks
mbostock
reviewed
Mar 17, 2023
mbostock
reviewed
Mar 20, 2023
Co-authored-by: Mike Bostock <mbostock@gmail.com>
Co-authored-by: Mike Bostock <mbostock@gmail.com>
Co-authored-by: Mike Bostock <mbostock@gmail.com>
Co-authored-by: Mike Bostock <mbostock@gmail.com>
mbostock
approved these changes
Mar 20, 2023
Member
There was a problem hiding this comment.
I tightened up the wording slightly, denoting the default parenthetically in the list, and split the paragraphs for the strict option to improve readability (since that was a bit long). I also clarified that the windowX and windowY transforms don’t just affect x and y respectively, they affect x, x1, and x2, and y, y1, and y2.
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* document Plot.window remarks: * *k* is not optional * *shift* is deprecated * added the *strict* option to README * adopt @deprecated * Update src/transforms/window.d.ts Co-authored-by: Mike Bostock <mbostock@gmail.com> * Update src/transforms/window.d.ts Co-authored-by: Mike Bostock <mbostock@gmail.com> * Update src/transforms/window.d.ts Co-authored-by: Mike Bostock <mbostock@gmail.com> * Update src/transforms/window.d.ts Co-authored-by: Mike Bostock <mbostock@gmail.com> * tweaks --------- Co-authored-by: Mike Bostock <mbostock@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remarks:
for #1343