Skip to content

document hexbin#1359

Merged
mbostock merged 5 commits into
mainfrom
fil/ts-hexbin
Mar 24, 2023
Merged

document hexbin#1359
mbostock merged 5 commits into
mainfrom
fil/ts-hexbin

Conversation

@Fil
Copy link
Copy Markdown
Contributor

@Fil Fil commented Mar 20, 2023

for #1343

(do we need to explain that it's an initializer?)

@Fil Fil requested a review from mbostock March 20, 2023 10:11
@mbostock mbostock enabled auto-merge (squash) March 24, 2023 03:41
@mbostock
Copy link
Copy Markdown
Member

(do we need to explain that it's an initializer?)

The return type should be Initialized<T> instead of Transformed<T>; fixed.

@mbostock mbostock merged commit 4abcec9 into main Mar 24, 2023
@mbostock mbostock deleted the fil/ts-hexbin branch March 24, 2023 03:44
Comment on lines +7 to +8
* The horizontal distance between centers of neighboring (pointy-topped)
* hexagons, in pixels; defaults to 20.
Copy link
Copy Markdown
Contributor Author

@Fil Fil Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distance between centers of neighboring hexagons is complete and correct :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course! Oops. Thanks for the correction.

chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* document hexbin

* default symbol hexagon

* edits

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants