Skip to content

document link#1388

Merged
mbostock merged 4 commits into
mainfrom
fil/ts-link
Mar 30, 2023
Merged

document link#1388
mbostock merged 4 commits into
mainfrom
fil/ts-link

Conversation

@Fil
Copy link
Copy Markdown
Contributor

@Fil Fil commented Mar 25, 2023

for #1343

note: more precise jsdoc for the curve option

todo:

  • maybeSameValue

@Fil Fil requested a review from mbostock March 25, 2023 17:19
Comment thread src/marks/link.d.ts Outdated
Copy link
Copy Markdown
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation for the maybeSameValue defaults?

Fil and others added 3 commits March 30, 2023 14:31
@mbostock mbostock enabled auto-merge (squash) March 30, 2023 21:48
@mbostock mbostock merged commit 0542835 into main Mar 30, 2023
@mbostock mbostock deleted the fil/ts-link branch March 30, 2023 21:51
@Fil
Copy link
Copy Markdown
Contributor Author

Fil commented Mar 30, 2023

Unnecessary repetition of instead:

   * If the plot uses a spherical **projection**, the default *auto* **curve**
   * will render links as geodesics; to draw a straight line instead, use the
   * *linear* **curve** instead.

@mbostock
Copy link
Copy Markdown
Member

Thanks, I will fix.

chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* document link

* Update src/marks/link.d.ts

Co-authored-by: Mike Bostock <mbostock@gmail.com>

* document link maybeSameValue

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants