document box#1394
Merged
Merged
Conversation
56 tasks
mbostock
reviewed
Mar 30, 2023
Member
mbostock
left a comment
mbostock
left a comment
There was a problem hiding this comment.
I think this needs a bit more explanation about the underlying group and map transforms.
mbostock
approved these changes
Mar 31, 2023
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* document box * remove unused accessor * adopt identity transform * edits --------- Co-authored-by: Mike Bostock <mbostock@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #1343
Say what happens with stroke/z? In my view it's technically working but hard to see if you don't add fillOpacity, so maybe it needs a bit more work.