skip intervals#1506
Merged
Merged
Conversation
Fil
approved these changes
Apr 28, 2023
Co-authored-by: Philippe Rivière <fil@rezo.net>
Member
Author
|
"2 quarters" is now supported. |
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* skip intervals * tiny bit of documentation * Apply suggestions from code review Co-authored-by: Philippe Rivière <fil@rezo.net> * prettier * LiteralTimeInterval; 3 quarters * test interval parsing --------- Co-authored-by: Philippe Rivière <fil@rezo.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1499. Also allows plural interval names such as years instead of requiring strictly year. Uses d3.unixDay instead of d3.utcDay for the day interval so that the intervals are uniformly spaced, matching the current behavior of d3.utcTicks.
Adding some unit tests for maybeTimeInterval and maybeUtcInterval would be nice…