index-aware map method#1559
Merged
Merged
Conversation
Contributor
|
Looks good. I'm trying to think of an example (for a unit test). |
Member
Author
|
I added some tests for custom map methods. |
Fil
approved these changes
May 15, 2023
mbostock
force-pushed
the
mbostock/map-taker
branch
from
b169a12 to
6ec5bf6
Compare
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* index-aware map method * fix type * fix jsdocs for MapFunction and ReducerFunction * copy edits * test custom map methods * test mapIndex, too --------- Co-authored-by: Philippe Rivière <fil@rezo.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. #1553 (comment)