Conversation
Merged
mbostock
force-pushed
the
mbostock/exclusive-facets
branch
from
15e303a to
fc59cae
Compare
mbostock
force-pushed
the
fil/exclusive-facets-reindex
branch
from
3292529 to
daeb7d4
Compare
mbostock
reviewed
Aug 18, 2023
| : typeof value?.transform === "function" | ||
| ? maybeTypedArrayify(value.transform(data), type) | ||
| : value && data?.reindex | ||
| ? maybeTypedMap(data.reindex, (i) => value[i], type) |
Member
There was a problem hiding this comment.
This assumes that value is an array, but it’s technically possible to be an arbitrary iterator. (Though, I discovered there’s some confusion in isOptions.)
mbostock
approved these changes
Aug 18, 2023
Member
mbostock
left a comment
mbostock
left a comment
There was a problem hiding this comment.
Nice! 👏
I switched to using a symbol since that seems cleaner/safer than assigning to array.reindex. (Who knows, maybe that’ll be a method in JavaScript in the future.) I also tweaked the logic slightly to handle channel values specified as iterables (even though there’s a latent confusion in isOptions or isObject that I’m not fixing here).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be working? (ref. #1649)
demo contrasting the three branches:
https://observablehq.com/@observablehq/plot-reindex-1662