figure max-width: initial#604
Merged
Merged
Conversation
Contributor
|
why do you prefer 100% in this case rather than max-width: initial like in the Inputs? (both seem to work in Observable) |
Member
Author
|
I thought you might ask that… No particular reason, really. The initial value of max-width is none, so we could just set it to that, too. initial, none, and 100% should be equivalent if there isn’t an explicit width set on the figure element. I suppose using max-width: none or max-width: initial would be less opinionated than max-width: 100% if there is, though, so I can switch to that. |
45b4f32 to
0f55d9c
Compare
Fil
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m not sure this is the “right” fix, but it feels like the safest and least invasive change to start. This way the figure max-width matches the SVG max-width. (It also roughly matches what we do with Inputs.table.)
Fixes #356.