channel aliases; mark.with#798
Draft
mbostock wants to merge 1 commit into
Draft
Conversation
Closed
Closed
mbostock
force-pushed
the
mbostock/mark-with
branch
from
e94c9e8 to
481f932
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #719; related #708 (comment). For example (note that the data is randomly generated, but the line and dots are consistent, hence demonstrating that the aliased values are not recomputed in the derived mark):
There are still some things to figure out here, though, like what does this mean for transforms? In this implementation, the transform is re-applied in the derived mark, but I don’t think we want that; I think instead the derived mark should somehow inherit the derived data and index from the source mark without recomputing the transform. Then any new channels on the derived mark would presumably be computed on the transformed data, similar to layouts?