Conversation
This was referenced Mar 16, 2022
Merged
Closed
mbostock
reviewed
Mar 22, 2022
Fil
force-pushed
the
fil/reinitialize-sort-hex-bins-plus-z
branch
from
a18c3e8 to
634bab9
Compare
group by z inline hexbin binWidth is the distance between two centers (rebased on mbostock/reinitialize)
Fil
force-pushed
the
fil/reinitialize-sort-hex-bins-plus-z
branch
from
73d764e to
526375e
Compare
Merged
mbostock
force-pushed
the
mbostock/reinitialize
branch
2 times, most recently
from
b305131 to
886615b
Compare
Member
mbostock
reviewed
May 27, 2022
Comment on lines
+45
to
+46
| X = X.value.map(x); | ||
| Y = Y.value.map(y); |
Member
There was a problem hiding this comment.
It isn’t safe to use X.value.map here because array.map returns the same type of array which may be a typed array such as Uint8Array. Or to put it another way, X.value is in data space, whereas the result of applying the x scale is in screen space and can be any number (such as Float64Array).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(includes the sort by r branch #808)
inlines an optimized version of hexbin