Custom vite resolver#881
Merged
Merged
Conversation
mythmon
approved these changes
May 24, 2022
mythmon
left a comment
mythmon
left a comment
There was a problem hiding this comment.
Ah, excellent. I was starting to look into having TS rewrite the imports, but that proved fruitless. This seems cleaner anyways.
Contributor
Author
Yeah, the TypeScript folks have taken a position against doing this: microsoft/TypeScript#16577 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #880 (comment)
This makes it so we can use "js" extensions for TypeScript imports by adding a custom resolver for Vite (which was the only piece that wasn't happy with the js extensions for files that don't exist. This custom loader won't be necessary once all of the files are TypeScript, since Vite implemented the typescript fallback for when importing from a typescript file..
With this change, I'm able to successfully run
yarn test,yarn dev, as well as import Plot as an ESM into another project.