Added an optional css class to the x/y axes#976
Closed
dgwyer wants to merge 1 commit into
Closed
Conversation
Closed
Contributor
|
Thanks for the contribution. I'm closing because we're probably going to revisit axes to change them to marks (see #1000), and we're also thinking about a generic className option that one could use on any mark (see #253, which would have to be rewritten as a "common option"). These two large generic changes would end up solving this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR! 🙂
Related. #6
This PR introduces optional CSS classes for the
xandyaxes.If
axisClassis not defined or isfalse, then no CSS classes get added to the plot. I kind of like the current clean tree of attributes that Plot creates by default. So I considered maintaining this and only adding CSS classes for axes if specifically opted in.If
axisClasshas been defined then it inserts the following classes. Note: Only the classes for the y-axis are shown below, but it's exactly the same for the x-axis if CSS classes are enabled.FYI - I've not added any docs for this PR yet. If it looks like it will be accepted then I'll update it of course.