remove spec from .mocharc.json#978
Merged
Merged
Conversation
duaneatat
approved these changes
Jul 11, 2022
mbostock
force-pushed
the
mbostock/mocha-spec
branch
from
583ec3f to
72615f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m not sure why this was added as part of TypeScript in #880, but having the spec in the .mocharc.json makes it harder to give Mocha a different spec from the command line. (It seems that Mocha ignores the spec on the command line in favor of the one in the .mocharc.json.) This changes makes it easier to run Mocha in watch mode on a custom spec, as shown in the CONTRIBUTING.md.