mark.channels is an object#994
Merged
Merged
Conversation
Member
Author
|
Maybe the channels argument to the Mark constructor should be an object, too? We might want to add some accommodation for backwards-compatibility if we change that, though. |
Member
Author
|
Okay I did the above thing, and I feel good about it being more consistent. It does mean we’re slightly more lax (we won’t detect when a mark declares a channel that duplicates one already declared by the built-in |
Fil
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken out of #979. We’re already using a channel object for mark.initialize (since #801) so it makes sense to use an object here, too.