Allow which results outside of /nix/store#3
Merged
ali-abrar merged 4 commits intoobsidiansystems:developfrom Oct 30, 2020
Merged
Allow which results outside of /nix/store#3ali-abrar merged 4 commits intoobsidiansystems:developfrom
ali-abrar merged 4 commits intoobsidiansystems:developfrom
Conversation
Ericson2314
reviewed
Sep 12, 2019
| @@ -0,0 +1,3 @@ | |||
| { pkgs ? import <nixpkgs> { } }: pkgs.haskellPackages.developPackage { | |||
Member
There was a problem hiding this comment.
I don't think we are adding "do nothing special" default.nixes like this any more. The CI does things automatically for repos without any nix files.
Member
|
Right, you should leave that default.nix file out in most cases.
…On Thu, 12 Sep 2019 at 15:37, John Ericson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In default.nix
<#3 (comment)>:
> @@ -0,0 +1,3 @@
+{ pkgs ? import <nixpkgs> { } }: pkgs.haskellPackages.developPackage {
I don't think we are adding "do nothing special" default.nixes like this
any more. The CI does things automatically for repos without any nix files.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=ABYWSRS3I5TOYFWYRI4ZVSLQJKLBDA5CNFSM4IWHWST2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCESVH3Q#pullrequestreview-287658990>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYWSRRRO3GD4FMZN7PSLWLQJKLBDANCNFSM4IWHWSTQ>
.
|
matthewbauer
force-pushed
the
allow-missing-nix-store
branch
from
3941559 to
90873ee
Compare
matthewbauer
force-pushed
the
allow-missing-nix-store
branch
from
90873ee to
04da6f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanups from #1 as well as allowing which results to be outside of /nix/store. This should make this package more general purpose for users who aren't using Nix.