Remove unnecessary Sugar.polynewtype#2467
Merged
gpetiot merged 1 commit intoocaml-ppx:mainfrom Oct 26, 2023
gpetiot:rm-sugar-polynewtype
Merged
Remove unnecessary Sugar.polynewtype#2467gpetiot merged 1 commit intoocaml-ppx:mainfrom gpetiot:rm-sugar-polynewtype
gpetiot merged 1 commit intoocaml-ppx:mainfrom
gpetiot:rm-sugar-polynewtype
Conversation
gpetiot
added
the
no changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Julow I was surprised that this code had no impact, I couldn't find a regression example, it looks like the parser never introduces this pattern, but a second review to confirm would be useful!
This makes #2401 easier, since there are heavy changes on the poly/newtypes constructors, and this code is a headache to maintain.