Fix: Ast_mapper.map_function_param should call arg_label#2473
Merged
gpetiot merged 1 commit intoocaml-ppx:mainfrom Nov 6, 2023
gpetiot:fix-max-function-param
Merged
Fix: Ast_mapper.map_function_param should call arg_label#2473gpetiot merged 1 commit intoocaml-ppx:mainfrom gpetiot:fix-max-function-param
gpetiot merged 1 commit intoocaml-ppx:mainfrom
gpetiot:fix-max-function-param
Conversation
gpetiot
added
the
no changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused a bug on
test-extra/code/base/src/map_intf.mlcaught by the CI of #2472, but introduced on main in #2471 (code was copied from the compiler in #2466).edit: the code in the compiler doesn't contain a function to map arg_labels, so nothing to fix on the compiler.