Skip to content

Fix Ppat_cons parenthesization in function parameter position#2476

Merged
gpetiot merged 2 commits intoocaml-ppx:mainfrom
mdelvecchio-jsc:fix-ppat-cons-fp-bug
Nov 7, 2023
Merged

Fix Ppat_cons parenthesization in function parameter position#2476
gpetiot merged 2 commits intoocaml-ppx:mainfrom
mdelvecchio-jsc:fix-ppat-cons-fp-bug

Conversation

@mdelvecchio-jsc
Copy link
Copy Markdown
Contributor

Fixes #2475.

@gpetiot gpetiot added the no changelog set this to bypass the CI check for changelog entries label Nov 7, 2023
@gpetiot gpetiot changed the title Fix Ppat_cons parenthesization in function parameter position. Fix Ppat_cons parenthesization in function parameter position Nov 7, 2023
Copy link
Copy Markdown
Collaborator

@gpetiot gpetiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

This has been introduced in #2471, so no need to add a changelog entry, but I added the test case from the issue.

@gpetiot gpetiot merged commit 5f796f2 into ocaml-ppx:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog set this to bypass the CI check for changelog entries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Error on Ppat_cons in function parameter

2 participants