Backport 5.2 changes to parser-standard#2512
Merged
Julow merged 7 commits intoocaml-ppx:mainfrom Oct 8, 2024
Merged
Conversation
Julow
added
the
no changelog
Collaborator
|
This only impacts |
Collaborator
Author
|
The tests are not passing due AST changes, which I think are due to parser-extended not being uptodate. |
TODO: Compiler libs shims are needed in Load_path and Builtin_attributes.
gpetiot
force-pushed
the
backport-52-standard
branch
from
f24bbe0 to
b86e1a9
Compare
Closed
Collaborator
Author
|
Merged over #2519 |
18 tasks
Julow
changed the title
Collaborator
Author
|
This PR is changed to backport the remaining parser and lexer changes except for |
Julow
commented
Oct 8, 2024
| text appears first in the list. | ||
| *) | ||
|
|
||
| %inline nonempty_concat(X): |
Collaborator
Author
There was a problem hiding this comment.
This code is not used but will be in #2544
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AST changes, perhaps due to parser-extended not being uptodate.
This might depend on #2503