[5.4 compat] effects keyword can be an attribute id#2714
Merged
Julow merged 2 commits intoocaml-ppx:mainfrom Oct 14, 2025
Merged
[5.4 compat] effects keyword can be an attribute id#2714Julow merged 2 commits intoocaml-ppx:mainfrom
Julow merged 2 commits intoocaml-ppx:mainfrom
Conversation
EmileTrotignon
added
the
no changelog
Collaborator
Author
|
No changelog because before |
Contributor
|
Note that the parser change is superseded by the ones in #2720, but I did not think about adding tests for those attributes, so this part sounds potentially useful. |
Collaborator
Author
|
Yeah, I don't think we can have to much tests. |
Julow
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address issue #2703
I added a test but I think its not great