Improve: less sensitivity to concrete syntax#767
Merged
gpetiot merged 9 commits intoocaml-ppx:masterfrom Apr 17, 2019
gpetiot:less-sensitivity-concrete-syntax
Merged
Improve: less sensitivity to concrete syntax#767gpetiot merged 9 commits intoocaml-ppx:masterfrom gpetiot:less-sensitivity-concrete-syntax
gpetiot merged 9 commits intoocaml-ppx:masterfrom
gpetiot:less-sensitivity-concrete-syntax
Conversation
gpetiot
commented
Apr 8, 2019
Julow
reviewed
Apr 9, 2019
Collaborator
Author
|
I fixed the regressions and made everything more predictable. |
Julow
approved these changes
Apr 15, 2019
Julow
approved these changes
Apr 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starts to address #747 (4 calls to
Location.is_single_lineremoved, a lot more to go, but the diff is already big enough).