test: regression with --force and cram tests#12028
Merged
rgrinberg merged 1 commit intoocaml:mainfrom Jul 28, 2025
Merged
Conversation
2747e23 to
d1336e4
Compare
rgrinberg
approved these changes
Jul 16, 2025
Member
rgrinberg
left a comment
There was a problem hiding this comment.
Thanks for catching this. For now, let's just note this in the changes. Using --force is only useful for broken cram tests anyway, and the issue is easily worked around by inserting a dummy edit into the test.
Collaborator
Author
|
For now, I've been doing |
Previously, --force would re-run already run cram tests. However this is no longer the case. Signed-off-by: Ali Caglayan <alizter@gmail.com>
d1336e4 to
6df5238
Compare
Collaborator
Author
|
If |
Member
|
We removed it internally because it was of little use. Not sure what we're going to do about it, but I wouldn't worry about it's fate very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, --force would re-run already run cram tests. However this is no longer the case.
Here is the test with 3.19 before #11994: