fix(oxcaml): instantiation of preprocessed modules#12843
Merged
Alizter merged 2 commits intoocaml:mainfrom Dec 5, 2025
Merged
Conversation
art-w
force-pushed
the
parameterised-pp
branch
2 times, most recently
from
22cedbc to
e456180
Compare
rgrinberg
approved these changes
Dec 2, 2025
Signed-off-by: Arthur Wendling <arthur@tarides.com>
Signed-off-by: Arthur Wendling <arthur@tarides.com>
art-w
force-pushed
the
parameterised-pp
branch
from
e456180 to
911ac2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #12707 : The preprocessed modules (may) have a different extension
.pp.ml, which conflicts withocamldepoutput if we try to read it naively (c.f. this check on the filename for which the dependencies were computed).