Skip to content

Remove [set_log_file] #12987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgrinberg merged 2 commits into from
Dec 16, 2025
Merged

Remove [set_log_file] #12987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba0f2bc
dev
rgrinberg Dec 9, 2025
b10fc21
refactor: remove unused [set_log_file] function
rgrinberg Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bin/common.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,6 @@ module Builder = struct
let forbid_builds t = { t with allow_builds = false; no_print_directory = true }
let default_root_is_cwd t = t.default_root_is_cwd
let set_default_root_is_cwd t x = { t with default_root_is_cwd = x }
let set_log_file t x = { t with log_file = x }
let disable_log_file t = { t with log_file = No_log_file }
let set_promote t v = { t with promote = Some v }
let default_target t = t.default_target
Expand Down
1 change: 0 additions & 1 deletion bin/common.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ module Builder : sig
val forbid_builds : t -> t
val default_root_is_cwd : t -> bool
val set_default_root_is_cwd : t -> bool -> t
val set_log_file : t -> Log.File.t -> t
val disable_log_file : t -> t
val set_promote : t -> Dune_engine.Clflags.Promote.t -> t
val default_target : t -> Arg.Dep.t
Expand Down
Loading