Skip to content

Add a test for setting constraints to dev tools#13036

Merged
Sudha247 merged 4 commits intoocaml:mainfrom
Sudha247:dev-tools-config-test
Mar 24, 2026
Merged

Add a test for setting constraints to dev tools#13036
Sudha247 merged 4 commits intoocaml:mainfrom
Sudha247:dev-tools-config-test

Conversation

@Sudha247
Copy link
Copy Markdown
Collaborator

This is essentially trying to show a minimal replication of #12850 with a mock opam repository.

Comment thread test/blackbox-tests/test-cases/pkg/ocamllsp/dev-tool-ocamllsp-configure.t Outdated
Copy link
Copy Markdown
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some additional simplifications to make the test run (slightly) faster.

Comment thread test/blackbox-tests/test-cases/pkg/ocamllsp/dev-tool-ocamllsp-configure.t Outdated
Comment thread test/blackbox-tests/test-cases/pkg/ocamllsp/dev-tool-ocamllsp-configure.t Outdated
Comment thread test/blackbox-tests/test-cases/pkg/ocamllsp/dev-tool-ocamllsp-configure.t Outdated
Comment thread test/blackbox-tests/test-cases/pkg/ocamllsp/dev-tool-ocamllsp-configure.t Outdated
@Sudha247 Sudha247 force-pushed the dev-tools-config-test branch from 05e74d8 to 6fce3f6 Compare January 23, 2026 19:21
@Sudha247 Sudha247 force-pushed the dev-tools-config-test branch from 6fce3f6 to 8b15e56 Compare January 27, 2026 10:58
@Sudha247 Sudha247 changed the title Add a reproduction case for #12851 and #12866 Add a test for setting constraints to dev tools Jan 27, 2026
@Sudha247 Sudha247 marked this pull request as ready for review January 27, 2026 11:09
Alizter added a commit that referenced this pull request Jan 27, 2026
#13036 was doing too many things at once. This test separated from the
PR, shows failure of autolocking when there are extra files, as reported
in #12851.
@Sudha247
Copy link
Copy Markdown
Collaborator Author

I initially put this on hold in the interest of larger discussions around dev tools (#12914). But @Leonidas-from-XIV rightly pointed out that this workflow is something we'd want to test even if we have a new rewrite of dev tools. I'm inclined to merge this.

Signed-off-by: Sudha Parimala <sudharg247@gmail.com>
Signed-off-by: Sudha Parimala <sudharg247@gmail.com>
Signed-off-by: Sudha Parimala <sudharg247@gmail.com>
Signed-off-by: Sudha Parimala <sudharg247@gmail.com>
@Sudha247 Sudha247 force-pushed the dev-tools-config-test branch from 8b15e56 to 83bdc37 Compare March 24, 2026 16:18
@Sudha247 Sudha247 merged commit 28ca331 into ocaml:main Mar 24, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants