fix(signal-watcher): don't assert false on SIGKILL#13370
Merged
anmonteiro merged 1 commit intoocaml:mainfrom Jan 19, 2026
Merged
fix(signal-watcher): don't assert false on SIGKILL#13370anmonteiro merged 1 commit intoocaml:mainfrom
assert false on SIGKILL#13370anmonteiro merged 1 commit intoocaml:mainfrom
Conversation
rgrinberg
approved these changes
Jan 19, 2026
Member
rgrinberg
left a comment
rgrinberg
left a comment
There was a problem hiding this comment.
No idea how this code path can be reached, but it seems harmless.
Could you leave a comment that this is for Mac in the code?
anmonteiro
force-pushed
the
anmonteiro/signal-watcher-sigkill
branch
from
547514b to
884eda5
Compare
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/signal-watcher-sigkill
branch
from
884eda5 to
d012e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on macOS, in a subset of cases, the signal watcher will catch both
SIGKILLandSIGINT.we ignore
SIGKILLinstead of runningassert false, which will kill the program less spectacularly.