Skip to content

Print diffs on patch back source tree diff failures#13697

Merged
rgrinberg merged 1 commit intoocaml:mainfrom
rgrinberg:push-nwonszlltkws
Mar 2, 2026
Merged

Print diffs on patch back source tree diff failures#13697
rgrinberg merged 1 commit intoocaml:mainfrom
rgrinberg:push-nwonszlltkws

Conversation

@rgrinberg
Copy link
Copy Markdown
Member

@rgrinberg rgrinberg commented Mar 1, 2026

Whenever we introduce a promotion due to patch back, we fail the action and make sure that a diff is printed. This is consistent with how we handle diffs elsewhere.

This PR is best read after #13696

@rgrinberg rgrinberg requested a review from anmonteiro March 1, 2026 03:08
@rgrinberg rgrinberg force-pushed the push-nwonszlltkws branch 2 times, most recently from c3575ce to a7b54b7 Compare March 1, 2026 04:03
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg rgrinberg force-pushed the push-nwonszlltkws branch from a7b54b7 to 46db3ad Compare March 2, 2026 13:52
@rgrinberg rgrinberg merged commit 4837c72 into ocaml:main Mar 2, 2026
12 of 13 checks passed
@shonfeder shonfeder mentioned this pull request Mar 2, 2026
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant