Print diffs on patch back source tree diff failures#13697
Merged
rgrinberg merged 1 commit intoocaml:mainfrom Mar 2, 2026
Merged
Print diffs on patch back source tree diff failures#13697rgrinberg merged 1 commit intoocaml:mainfrom
rgrinberg merged 1 commit intoocaml:mainfrom
Conversation
c3575ce to
a7b54b7
Compare
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
a7b54b7 to
46db3ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever we introduce a promotion due to patch back, we fail the action and make sure that a diff is printed. This is consistent with how we handle diffs elsewhere.
This PR is best read after #13696