remove rowKeyElement dependencies test for code review #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JackShi148
force-pushed
the
rm_rowkeyelement_test
branch
2 times, most recently
from
a5a224f to
64c75f1
Compare
GroundWu
reviewed
Jul 22, 2024
src/main/java/com/alipay/oceanbase/rpc/location/model/partition/ObKeyPartDesc.java
Outdated
Show resolved
Hide resolved
GroundWu
reviewed
Jul 22, 2024
src/main/java/com/alipay/oceanbase/rpc/location/model/partition/ObHashPartDesc.java
Outdated
Show resolved
Hide resolved
JackShi148
force-pushed
the
rm_rowkeyelement_test
branch
from
553aa64 to
71579fd
Compare
WeiXinChan
reviewed
Sep 13, 2024
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove addRowKeyElement dependency on new Mutation interface (Insert, Update, InsertOrUpdate etc.)
Summary
Users now can use new interfaces to provide row key name and value when create the operation, do not need to use addRowKeyElement before operations.
Solution Description
The internal process will work for old interfaces and new interfaces. The old process will concat the value with the name and calculate partition Id, the new process will directly carry the value with the name to the calculation part. Remove previous redundant processing.