Skip to content

Fix global route refresh wrong #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenyunlong merged 3 commits into from
Nov 14, 2024
Merged

Fix global route refresh wrong #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2af40bc
fix global index route refresh wrong when route need refresh
GroundWu Nov 12, 2024
d51acc5
fix global index route wrong
GroundWu Nov 13, 2024
c70d6cc
revert unused commit
GroundWu Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...m/alipay/oceanbase/rpc/protocol/payload/impl/execute/query/AbstractQueryStreamResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ protected ObPayload commonExecute(ObTableClient client, Logger logger,
result = subObTable.executeWithConnection(request, connectionRef);
} else {
result = subObTable.execute(request);

if (result != null && result.getPcode() == Pcodes.OB_TABLE_API_MOVE) {
ObTableApiMove moveResponse = (ObTableApiMove) result;
client.getRouteTableRefresher().addTableIfAbsent(indexTableName, true);
Expand Down Expand Up @@ -258,7 +257,7 @@ protected ObPayload commonExecute(ObTableClient client, Logger logger,
((ObTableException) e).getErrorCode(), tryTimes, e);
// tablet not exists, refresh table entry
if (e instanceof ObTableNeedFetchAllException) {
client.getOrRefreshTableEntry(tableName, true, true, true);
client.getOrRefreshTableEntry(indexTableName, true, true, true);
throw e;
}
} else {
Expand Down Expand Up @@ -576,7 +575,8 @@ public void init() throws Exception {
RUNTIME.error("Fail to get refresh table entry response after {}",
retryTimes);
throw new ObTableRetryExhaustedException(
"Fail to get refresh table entry response after " + retryTimes);
"Fail to get refresh table entry response after " + retryTimes +
"errorCode:" + ((ObTableNeedFetchAllException) e).getErrorCode());

}
} else {
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/com/alipay/oceanbase/rpc/stream/ObTableClientQueryAsyncStreamResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ public void init() throws Exception {
RUNTIME.error("Fail to get refresh table entry response after {}",
retryTimes);
throw new ObTableRetryExhaustedException(
"Fail to get refresh table entry response after " + retryTimes);
"Fail to get refresh table entry response after " + retryTimes
+ "errorCode:" + ((ObTableNeedFetchAllException) e).getErrorCode());

}
} else {
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/alipay/oceanbase/rpc/table/ObTableClientQueryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ ObTableClientQueryAsyncStreamResult execute() throws Exception {
public Map<Long, ObPair<Long, ObTableParam>> initPartitions(ObTableQuery tableQuery, String tableName) throws Exception {
Map<Long, ObPair<Long, ObTableParam>> partitionObTables = new LinkedHashMap<>();
String indexName = tableQuery.getIndexName();
String indexTableName = null;

if (!this.obTableClient.isOdpMode()) {
indexTableName = obTableClient.getIndexTableName(tableName, indexName, tableQuery.getScanRangeColumns(), false);
Expand Down