Skip to content

modify version control for direct-load partition #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WeiXinChan merged 1 commit into from
Nov 20, 2024
Merged

modify version control for direct-load partition #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/main/java/com/alipay/oceanbase/rpc/direct_load/protocol/v0/ObDirectLoadProtocolV0.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ public class ObDirectLoadProtocolV0 implements ObDirectLoadProtocol {

public static final long OB_VERSION_4_3_2_0 = ObGlobal.calcVersion(4, (short) 3,
(byte) 2, (byte) 0);
public static final long OB_VERSION_4_3_5_0 = ObGlobal.calcVersion(4, (short) 3,
(byte) 5, (byte) 0);

private static final int PROTOCOL_VERSION = 0;
private final ObDirectLoadLogger logger;
Expand Down Expand Up @@ -63,12 +65,14 @@ public void checkIsSupported(ObDirectLoadStatement statement) throws ObDirectLoa
+ " is not supported, minimum version required is "
+ ObGlobal.getObVsnString(OB_VERSION_4_3_2_0));
}
} else if (statement.getPartitionNames().length > 0) {
} else if (obVersion < OB_VERSION_4_3_5_0 && statement.getPartitionNames().length > 0) {
logger.warn("partition names in ob version " + ObGlobal.getObVsnString(obVersion)
+ "is not supported");
+ "is not supported, minimum version required is "
+ ObGlobal.getObVsnString(OB_VERSION_4_3_5_0));
throw new ObDirectLoadNotSupportedException("partition names in ob version "
+ ObGlobal.getObVsnString(obVersion)
+ " is not supported");
+ ObGlobal.getObVsnString(obVersion)
+ " is not supported, minimum version required is "
+ ObGlobal.getObVsnString(OB_VERSION_4_3_5_0));
}
}

Expand Down