-
Notifications
You must be signed in to change notification settings - Fork 49
Including the tutorials #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A first pass at including the tutorials on the website
✅ Deploy Preview for oceanhackweek-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
It looks like if a notebook doesn't have a clear title, then Sphinx gets cranky and won't include it. ohw22/tutorials-index/data-access-in-python.md:3: WARNING: toctree contains reference to document 'ohw22/tutorials/01-Tue/00-data-access-in-python/03-extras-argopy-erddap' that doesn't have a title: no link will be generated
ohw22/tutorials-index/espanol/python-cientifico.md:3: WARNING: toctree contains reference to document 'ohw22/tutorials/optional/espanol/python-cientifico/intro_to_python_ohw2022' that doesn't have a title: no link will be generated
ohw22/tutorials-index/espanol/python-cientifico.md:3: WARNING: toctree contains reference to document 'ohw22/tutorials/optional/espanol/python-cientifico/Intro_to_plot' that doesn't have a title: no link will be generated
ohw22/tutorials-index/espanol/python-cientifico.md:3: WARNING: toctree contains reference to document 'ohw22/tutorials/optional/espanol/python-cientifico/intro_to_netcdf' that doesn't have a title: no link will be generated
ohw22/tutorials-index/data-access-in-python.md:3: WARNING: toctree contains reference to document 'ohw22/tutorials/01-Tue/00-data-access-in-python/03-extras-argopy-erddap' that doesn't have a title: no link will be generatedThis happens even if you try to give it an explicit title in the toctree, so there may be some cleanup of tutorial notebooks that we may want to do if we want to include them on the site. |
|
Wow, thank you! Looks awesome, even more so for a first try.
I'll work on adding titles to the notebooks in Question: how does it handle R notebooks (or whatever the right R terminology is)? For the |
Thanks, then I don't have to invent what things might be called. Please suggest edits for anything I've putzed the spelling up on.
Juyptext is reading the I don't believe I included https://github.com/oceanhackweek/ohw-tutorials/tree/OHW22/optional/espanol/datos-espaciales-tidy which would be why it's not displaying. |
Thanks. I've been looking into Jupytext for doing this in a Jupyterbook, but w/o necessarily having an R conda env to execute the notebook. I assume in this case it's reusing the OHW22 R conda env to execute the Rmd's? Otherwise, unlike a pre-executed Jupyter notebook, Rmd notebooks don't include the output. |
Neither Jupyter nor R notebooks are getting executed, so it's just whatever they are saved with. I think Sphinx can directly include basic |
|
I see. Thanks. I won't spend more time thinking about it either, until OHW is over. |
emiliom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great, user-friendliness wise, if the TOC that's generated in https://deploy-preview-199--oceanhackweek-preview.netlify.app/ohw22/tutorials-index/index.html could be trimmed to only 2-levels deep, or heck maybe just one-level deep (Getting started, plus the list of tutorials).
Also in https://deploy-preview-199--oceanhackweek-preview.netlify.app/ohw22/tutorials-index/index.html (and likewise https://deploy-preview-199--oceanhackweek-preview.netlify.app/ohw22/tutorials-index/data-access-in-python.html), the TOC for Data access in Python is weird. The 00- notebook's sections get fleshed out in excruciating detail, and then the last two notebooks (02- and 04-) appear at the end as single TOC entries that might as well be another section in 00-.
Anyways, just observations. I'd go ahead and merge the PR. IMHO having the tutorials on the web site like you have done, despite these quirks, is more helpful than not having them.
Tweaked
I think that's the header depth from the notebooks themselves not being super clear. We can do a pass over the tutorials afterwards producing outputs and cleaning up hierarchy. |
|
Great. Looks much better. Merge while you're ahead. |
FIFY |
A first pass at including the tutorials on the website