Skip to content
This repository was archived by the owner on Oct 2, 2024. It is now read-only.

Add webhook support and prometheus#76

Closed
dkess wants to merge 1 commit into
masterfrom
webhook-prom
Closed

Add webhook support and prometheus#76
dkess wants to merge 1 commit into
masterfrom
webhook-prom

Conversation

@dkess
Copy link
Copy Markdown
Member

@dkess dkess commented Dec 26, 2018

Curious on people's thoughts on this. Instead of creating a new service to process IRC webhooks, we can use create's HTTP server. This could also be used to capture GitHub webhooks.

@kpengboy
Copy link
Copy Markdown
Member

kpengboy commented Jan 4, 2019

Sounds OK, given that we already use create for Debian security advisories and the like.

If you choose to go this route, though, best would be to make the webserver its own module and register handlers through other modules. (Perhaps consider Flask?)

@dkess
Copy link
Copy Markdown
Member Author

dkess commented Jan 5, 2019

Hmm, Flask sounds like be a good idea. Might close this at some point and re-open with a different design approach.

Copy link
Copy Markdown
Member

@jvperrin jvperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd agree with @kpengboy that splitting out the web server (and maybe using Flask) and then having some kind of plugin hook system for the web server would be better than this.

@dkess dkess closed this Jan 14, 2019
@dkess dkess deleted the webhook-prom branch January 14, 2019 23:18
@fydai
Copy link
Copy Markdown
Contributor

fydai commented Jun 2, 2019

We should be able to do this now, with the new Flask setup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants