Skip to content
This repository was archived by the owner on Aug 9, 2025. It is now read-only.

Riot Client#13

Merged
nikhiljha merged 10 commits into
masterfrom
riot
Apr 29, 2020
Merged

Riot Client#13
nikhiljha merged 10 commits into
masterfrom
riot

Conversation

@nikhiljha
Copy link
Copy Markdown
Member

@nikhiljha nikhiljha commented Apr 26, 2020

closes #11

I used chat.ocf.berkeley.edu as the domain. I'm pretty sure that wasn't final, so... suggestions maybe?

Again, configs are "heavily inspired" by https://github.com/ananace/matrix-synapse

@nikhiljha nikhiljha requested review from cg505 and encadyma April 26, 2020 17:11
@nikhiljha nikhiljha added the enhancement New feature or request label Apr 26, 2020
Copy link
Copy Markdown
Member

@cg505 cg505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this!

I think it would be better to build config.json into the Dockerfile, which is usually what we do for static config files that don't include secrets. We also will need to add LDAP/DNS records for chat.ocf.berkeley.edu.

It's worth considering whether riot should be its own repo entirely. It doesn't actually share anything with synapse.

Comment thread kubernetes/riot.yml.erb Outdated
Copy link
Copy Markdown
Member

@encadyma encadyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juicy work

Comment thread kubernetes/riot.yml.erb Outdated
@nikhiljha
Copy link
Copy Markdown
Member Author

In my head, you wouldn't really have Riot without Matrix, so it makes sense that they're together? Idk.

Anyway the config is copied into the container now. Is there a way I can build & test this? It's a new k8s service, so it should be easier than testing the haproxy stuff I hope?

Copy link
Copy Markdown
Member

@cg505 cg505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good except for a couple comments

Comment thread .gitignore Outdated
Comment thread Dockerfile.riot Outdated
@nikhiljha nikhiljha requested review from cg505 and encadyma April 29, 2020 18:54
@nikhiljha nikhiljha merged commit a61d19e into master Apr 29, 2020
@nikhiljha nikhiljha deleted the riot branch April 29, 2020 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Riot client

3 participants