add fishpaper and printer status query#287
Merged
Merged
Conversation
jaysa68
previously approved these changes
May 6, 2026
Member
jaysa68
left a comment
jaysa68
left a comment
There was a problem hiding this comment.
rebase on main and ensure tests pass + it builds, then you are good to go!
Contributor
Author
|
going to add paper tray status too |
BNH440
force-pushed
the
printer-stats-update
branch
from
e2837b3 to
45f2b16
Compare
24apricots
approved these changes
May 6, 2026
| import puresnmp | ||
|
|
||
| PRINTERS = ['logjam', 'pagefault', 'papercut'] | ||
| PRINTERS = ['logjam', 'pagefault', 'papercut', 'fishpaper'] |
Member
There was a problem hiding this comment.
can we query ldap and get printers in prod env
Contributor
Author
There was a problem hiding this comment.
that would be nice but probably not realistic right now as we'd also need to tell the difference between hp printers and not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds fishpaper to list of printers and adds a way to query the printer status string via snmp (gets data like if printer is out of paper)