add mount for config with secrets#9
Merged
Merged
Conversation
cg505
approved these changes
Apr 23, 2020
Member
cg505
left a comment
cg505
left a comment
There was a problem hiding this comment.
maybe we should add a comment at the top of the config.js in this repository to point out that this is not the one that is used in production
ja5087
force-pushed
the
k8s-mount-secret-cfg
branch
from
32660be to
8866bcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to store the password for WEBIRC in #8. It should mount on top of the config.js copied in.